Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(recipe-parsing): fix recipe config parsing for $ #4258

Merged
merged 17 commits into from
Mar 2, 2022
Merged

fix(recipe-parsing): fix recipe config parsing for $ #4258

merged 17 commits into from
Mar 2, 2022

Conversation

MugdhaHardikar-GSLab
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@MugdhaHardikar-GSLab
fix(spark-lineage): select mock server port dynamically for unit test
09441d3
@MugdhaHardikar-GSLab
refactor(spark-lineage): remove dependency of spark from McpEmitter
cac9e4b
@MugdhaHardikar-GSLab
fix(spark-lineage): fix checkstyle issues
6f64a20
@MugdhaHardikar-GSLab
fix(spark-lineage): restore consumers
8270c24
@MugdhaHardikar-GSLab
Merge branch 'linkedin:master' into master
dffa6c4
@MugdhaHardikar-GSLab
refactor(spark-lineage): enhance logging and documentation
1675dfe
@MugdhaHardikar-GSLab
Update McpEmitter.java
d6583fc
@MugdhaHardikar-GSLab
add debugging section
8e9291c
@MugdhaHardikar-GSLab
refactor(spark-lineage): enhance logs
7ba4ddf
@MugdhaHardikar-GSLab
Merge branch 'spark-logging' of https://github.com/MugdhaHardikar-GSL…
d396664 
…ab/datahub into spark-logging
@MugdhaHardikar-GSLab
Merge pull request #1 from MugdhaHardikar-GSLab/spark-logging
08b51d7 
refactor(spark-lineage): enhance logging and documentation
@MugdhaHardikar-GSLab
Add https and auth token support
2c54135
@MugdhaHardikar-GSLab
Merge branch 'linkedin:master' into master
7b8ae31
@MugdhaHardikar-GSLab
Merge branch 'linkedin:master' into master
c59bd78
@MugdhaHardikar-GSLab
fix(recipe-parsing): fix recipe config parsing for $
aa4b3ef
@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

Unit Test Results (build & test)

  71 files  +  1    71 suites  +1   17m 41s ⏱️ + 11m 34s
618 tests +77  559 ✔️ +70  59 💤 +7  0 ❌ ±0 

Results for commit 78fe124. ± Comparison against base commit a113e43.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 25, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   46m 36s ⏱️ + 2m 26s
   342 tests ±0     342 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
1 557 runs  ±0  1 526 ✔️ ±0  31 💤 ±0  0 ❌ ±0 

Results for commit 78fe124. ± Comparison against base commit a113e43.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit ec26b0d into datahub-project:master Mar 2, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@MugdhaHardikar-GSLab @maggiehays
fix(ingest): fix config parsing for $ (datahub-project#4258)
d458f2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MugdhaHardikar-GSLab @shirshanka