Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui) Misc styling fixes (truncated filter values, updating tag color on clickaway) #4246

Merged
merged 2 commits into from
Feb 24, 2022
Merged

fix(ui) Misc styling fixes (truncated filter values, updating tag color on clickaway) #4246

merged 2 commits into from
Feb 24, 2022

Conversation

jjoyce0510
Copy link
Collaborator

Changes:

  1. Truncate long filter values, show full value in popover.
  2. Fix styling when long tags cause the entity title to wrap in search.
  3. Fix Tag Color Picker on profile page to save color when user clicks out of color picker.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  70 files  +  70    70 suites  +70   16m 19s ⏱️ + 16m 19s
611 tests +611  552 ✔️ +552  59 💤 +59  0 ❌ ±0 

Results for commit 7cdcd88. ± Comparison against base commit 826abb8.

@shirshanka shirshanka merged commit 5d0915e into datahub-project:master Feb 24, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@jjoyce0510 @maggiehays
fix(ui) Misc styling fixes (truncated filter values, updating tag col…
7def08c 
…or on clickaway) (datahub-project#4246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @shirshanka