Resign the policy tab #4232

Ankit-Keshari-Vituity · 2022-02-23T12:23:58Z

"Redesign the Policies tab

Change the complete UI of policies Tab
Added a paragraph under Manage Policies --> Manage access for users & groups of DataHub using Policies
Add a Table instead of a list to show the data
Add columns Name, Type, Description, Actors, State, and Actions
Table Columns:

Name --> Clicking on name opens the details modal
Type --> "Platform" or "Metadata"
Description
Actors
State -> Active vs Inactive
Actions: Edit Policy, Deactivate / Activate Policy, Delete Policy

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable)

github-actions · 2022-02-23T12:50:11Z

Unit Test Results (build & test)

  71 files ±0   71 suites ±0 11m 58s ⏱️ - 8m 40s
618 tests ±0 559 ✔️ +1 59 💤 ±0 0 ❌ - 1

Results for commit 65b85cd. ± Comparison against base commit 77a2735.

♻️ This comment has been updated with latest results.

Ankit-Keshari-Vituity · 2022-02-24T15:21:12Z

Fixed the CSS issue.

Border fix for state column
Tags for "All Users" and "All Groups" on the right side of AvatarGroup (if fields allUsers / allGroups are true)

…ahub into redesign-policy-tab

… Users

…ould be user readable task

…in between the privileges

jjoyce0510 · 2022-03-03T02:13:16Z

datahub-web-react/src/app/policy/PoliciesPage.tsx

                    onClose={onCancelViewPolicy}
-                    onRemove={onRemovePolicy}
-                    onToggleActive={onToggleActive}
+                    privileges={privileges}


what if we had a prop called

"getPrivilegeDisplayName(type: string) => string"

jjoyce0510 · 2022-03-03T02:16:53Z

datahub-web-react/src/app/policy/PolicyDetailsModal.tsx

    onClose: () => void;
-    onRemove: () => void;
-    onToggleActive: (value: boolean) => void;
+    privileges: any;


Change this type to Array

Changed and committed

jjoyce0510 · 2022-03-03T02:18:37Z

datahub-web-react/src/app/policy/PolicyDetailsModal.tsx

+                                />
+                            ))}
+                        </Col>
+                        <Col flex={1} style={{ display: 'flex', justifyContent: 'end' }}>


Bring the "All Users" tag to the left at the end of the avatar row (same column)

jjoyce0510 · 2022-03-03T02:19:35Z

datahub-web-react/src/app/policy/PolicyDetailsModal.tsx

+                                />
+                            ))}
+                        </Col>
+                        <Col flex={1} style={{ display: 'flex', justifyContent: 'end' }}>


Try to use styled components any time there is inline styling overrides

jjoyce0510 · 2022-03-03T02:20:23Z

datahub-web-react/src/app/policy/PoliciesPage.tsx

+                <ActionButtonContainer>
+                    <Button
+                        disabled={!record?.editable}
+                        style={{ marginRight: 16 }}


Move to styled components

Changed and committed

jjoyce0510 · 2022-03-03T02:20:43Z

datahub-web-react/src/app/policy/PoliciesPage.tsx

+                                    />
+                                ))}
+                            </Col>
+                            <Col flex={1} style={{ display: 'flex', justifyContent: 'end' }}>


Remove inline styling

jjoyce0510 · 2022-03-03T02:22:07Z

datahub-web-react/src/app/policy/PoliciesPage.tsx

                    onClose={onCancelViewPolicy}
-                    onRemove={onRemovePolicy}
-                    onToggleActive={onToggleActive}
+                    privileges={privileges}


privileges={getPrivileges(focusPolicy)}

And remove the state

Changed and committed

jjoyce0510 · 2022-03-03T02:23:03Z

datahub-web-react/src/app/policy/PoliciesPage.tsx

@@ -139,10 +173,31 @@ export const PoliciesPage = () => {
        setShowPolicyBuilderModal(false);
    };

+    const getPrivileges = (policy: Policy) => {


rename to "getPrivilegeNames"

Changed and committed

jjoyce0510 · 2022-03-03T02:23:56Z

datahub-web-react/src/app/policy/PoliciesPage.tsx

+
+    const tableData = policies?.map((policy) => ({
+        urn: policy?.urn,
+        policy,


Do we need this here? Or can we remove

Removed and committed

jjoyce0510 · 2022-03-03T02:24:17Z

datahub-web-react/src/app/policy/PoliciesPage.tsx

+                <PoliciesHeaderContainer>
+                    <PoliciesTitle level={2}>Manage Policies</PoliciesTitle>
+                    <Typography.Paragraph type="secondary">
+                        Manage access for users & groups of DataHub using Policies.


"Manage access for Users & Groups of DataHub using Policies."

Changed and committed

Resign the policy tab

646f7a2

CSS Fixes

4a26079

Ankit-Keshari-Vituity added 4 commits March 1, 2022 06:24

Merge branch 'master' of https://github.com/Ankit-Keshari-Vituity/dat…

713786e

…ahub into redesign-policy-tab

Policy page: Worked on actors column, Applies to group and Applies to…

1c5c5b4

… Users

Policy View Moda: Worked on Display privileges data and Privileges sh…

0305c61

…ould be user readable task

Worked on: Disabled the edit and delete button && Added vertical marg…

3974985

…in between the privileges

jjoyce0510 reviewed Mar 3, 2022

View reviewed changes

Ankit-Keshari-Vituity added 2 commits March 3, 2022 12:19

Fixed privileges issue

d2f0694

Completed the resigning of policies page

65b85cd

shirshanka approved these changes Mar 4, 2022

View reviewed changes

shirshanka merged commit d96241c into datahub-project:master Mar 4, 2022

maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022

Resign the policy tab (datahub-project#4232)

a4fc286

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resign the policy tab #4232

Resign the policy tab #4232

Ankit-Keshari-Vituity commented Feb 23, 2022

github-actions bot commented Feb 23, 2022 •

edited

Loading

Ankit-Keshari-Vituity commented Feb 24, 2022

jjoyce0510 Mar 3, 2022

jjoyce0510 Mar 3, 2022

Ankit-Keshari-Vituity Mar 3, 2022 •

edited

Loading

jjoyce0510 Mar 3, 2022

jjoyce0510 Mar 3, 2022

jjoyce0510 Mar 3, 2022

Ankit-Keshari-Vituity Mar 3, 2022

jjoyce0510 Mar 3, 2022

jjoyce0510 Mar 3, 2022

jjoyce0510 Mar 3, 2022

Ankit-Keshari-Vituity Mar 3, 2022

jjoyce0510 Mar 3, 2022

Ankit-Keshari-Vituity Mar 3, 2022

jjoyce0510 Mar 3, 2022

Ankit-Keshari-Vituity Mar 3, 2022

jjoyce0510 Mar 3, 2022

Ankit-Keshari-Vituity Mar 3, 2022

Resign the policy tab #4232

Resign the policy tab #4232

Conversation

Ankit-Keshari-Vituity commented Feb 23, 2022

Checklist

github-actions bot commented Feb 23, 2022 • edited Loading

Unit Test Results (build & test)

Ankit-Keshari-Vituity commented Feb 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ankit-Keshari-Vituity Mar 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 23, 2022 •

edited

Loading

Ankit-Keshari-Vituity Mar 3, 2022 •

edited

Loading