feat(profiling) - Bigquery: Ability to disable partition profiling #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating profiling bigquery temp tables in the schema where the profiling table is by default.
rslanka
reviewed
Feb 25, 2022
| @@ -43,6 +43,7 @@ class GEProfilingConfig(ConfigModel): | |||
| # Hidden option - used for debugging purposes. | |||
| catch_exceptions: bool = True | |||
|
|
|||
| partition_profiling_enabled: Optional[bool] = True | |||
There was a problem hiding this comment.
Remove Optional since the default value True will always be present.
rslanka
reviewed
Feb 25, 2022
| and not self.config.profiling.partition_profiling_enabled | ||
| ): | ||
| logger.debug( | ||
| f"{dataset_name} is skipped because profiling.partition_profiling_enabled property is disabled" |
There was a problem hiding this comment.
probably include the partition as well in the debug message.
rslanka
reviewed
Feb 25, 2022
| f"{self.config.bigquery_temp_table_schema}.ge-temp-{uuid.uuid4()}" | ||
| ) | ||
| ge_config["bigquery_temp_table"] = bigquery_temp_table | ||
| if custom_sql or self.config.limit or self.config.offset: |
There was a problem hiding this comment.
Can you add comments about when and why the temp table is being created? The logic has a significant change from the earlier code.
rslanka
reviewed
Feb 25, 2022
| @@ -167,7 +171,7 @@ views by setting `profiling.bigquery_temp_table_schema` property. | |||
| :::note | |||
|
|
|||
| Due to performance reasons, we only profile the latest partition for Partitioned tables and the latest shard for sharded tables. | |||
|
|
|||
| If you want you can set partiton you want partiton by setting `partition.partition_datetime` property. (this will be applied to all partitioned tables) | |||
There was a problem hiding this comment.
Typos If you want you can set partiton you want partiton?
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist