feat(ingest): add lineage_client_project_id field to the BigQuery config #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcs9
force-pushed
the
bq-query-project
branch
2 times, most recently
from
e0121f6 to
2e08675
Compare
treff7es
reviewed
Feb 16, 2022
| @@ -336,7 +337,11 @@ def _compute_bigquery_lineage_via_gcp_logging(self) -> None: | |||
| def _compute_bigquery_lineage_via_exported_bigquery_audit_metadata(self) -> None: | |||
| logger.info("Populating lineage info via exported GCP audit logs") | |||
| try: | |||
| _client: BigQueryClient = BigQueryClient(project=self.config.project_id) | |||
| if self.config.lineage_client_project_id is None: | |||
There was a problem hiding this comment.
Is this only for exported_bigquery_audit_metadata?
There was a problem hiding this comment.
For our use case, we only need it for the exported_bigquery_audit_metadata, but I can also add to the code that makes the client for _compute_bigquery_lineage_via_gcp_logging()
| @@ -336,7 +337,11 @@ def _compute_bigquery_lineage_via_gcp_logging(self) -> None: | |||
| def _compute_bigquery_lineage_via_exported_bigquery_audit_metadata(self) -> None: | |||
| logger.info("Populating lineage info via exported GCP audit logs") | |||
| try: | |||
| _client: BigQueryClient = BigQueryClient(project=self.config.project_id) | |||
| if self.config.lineage_client_project_id is None: | |||
| self.config.lineage_client_project_id = self.config.project_id | |||
There was a problem hiding this comment.
I would not overwrite the config value if possible but I would store it in a local variable just to be on the safe side like
project_id:str = self.config.lineage_client_project_id if self.config.lineage_client_project_id else self.config.project_id
_client: BigQueryClient = BigQueryClient(
project=project_id
)
feldjay
reviewed
Feb 18, 2022
| if project_id is not None: | ||
| return [GCPLoggingClient(**client_options, project=project_id)] | ||
| else: | ||
| return [GCPLoggingClient(**client_options)] | ||
|
|
||
| def _choose_lineage_client_project_id(self) -> Optional[str]: |
There was a problem hiding this comment.
Minor: I'd make this _get for consistency and clarity (since this method doesn't actually accept any inputs)
Maybe this should be a property so the value is only computed once instead of on each function call?
vcs9
force-pushed
the
bq-query-project
branch
from
62b2c31 to
2e4f24d
Compare
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…fig (datahub-project#4138) * feat(ingest): add lineage_client_project_id field to the bigquery config * fix linting issues * add type annotation for arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to specify which project to use when creating the BigQuery client, in case the default project_id is not used for querying.
Checklist