-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cypress): force clicks on tag mutation test #4102
Merged
shirshanka
merged 9 commits into
datahub-project:master
from
gabe-lyons:gabe--fixDetachedDomIssuesMutationTagTest
Feb 12, 2022
Merged
fix(cypress): force clicks on tag mutation test #4102
shirshanka
merged 9 commits into
datahub-project:master
from
gabe-lyons:gabe--fixDetachedDomIssuesMutationTagTest
Feb 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexter-mh-lee
approved these changes
Feb 9, 2022
gabe-lyons
force-pushed
the
gabe--fixDetachedDomIssuesMutationTagTest
branch
from
February 9, 2022 22:01
f0ba1c0
to
028344c
Compare
…ionTagTest' into gabe--fixDetachedDomIssuesMutationTagTest
…ionTagTest' into gabe--fixDetachedDomIssuesMutationTagTest
shirshanka
approved these changes
Feb 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ne1r0n
pushed a commit
to ne1r0n/datahub
that referenced
this pull request
Feb 13, 2022
* fix detached from dom issue in modal clicks * warm up ES cache * warm up ES cache * trying to connect cypress w/ dashboard * fix spacing * record the run * reverting cypress cli stuff
hevandro-veiga
pushed a commit
to hevandro-veiga/datahub
that referenced
this pull request
Feb 18, 2022
* fix detached from dom issue in modal clicks * warm up ES cache * warm up ES cache * trying to connect cypress w/ dashboard * fix spacing * record the run * reverting cypress cli stuff
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
* fix detached from dom issue in modal clicks * warm up ES cache * warm up ES cache * trying to connect cypress w/ dashboard * fix spacing * record the run * reverting cypress cli stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These clicks fail sometimes due to confusion cypress has w/ clicking buttons on modals. Hopefully this clears up the spurious failure.
cc @dexter-mh-lee
Checklist