Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): force clicks on tag mutation test #4102

Conversation

gabe-lyons
Copy link
Contributor

These clicks fail sometimes due to confusion cypress has w/ clicking buttons on modals. Hopefully this clears up the spurious failure.

cc @dexter-mh-lee

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unit Test Results (build & test)

  70 files  +1    70 suites  +1   14m 14s ⏱️ + 3m 53s
609 tests +5  550 ✔️ +6  59 💤 ±0  0  - 1 

Results for commit 57d6bba. ± Comparison against base commit 2d7452d.

♻️ This comment has been updated with latest results.

@gabe-lyons gabe-lyons force-pushed the gabe--fixDetachedDomIssuesMutationTagTest branch from f0ba1c0 to 028344c Compare February 9, 2022 22:01
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 06bb033 into datahub-project:master Feb 12, 2022
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
* fix detached from dom issue in modal clicks

* warm up ES cache

* warm up ES cache

* trying to connect cypress w/ dashboard

* fix spacing

* record the run

* reverting cypress cli stuff
hevandro-veiga pushed a commit to hevandro-veiga/datahub that referenced this pull request Feb 18, 2022
* fix detached from dom issue in modal clicks

* warm up ES cache

* warm up ES cache

* trying to connect cypress w/ dashboard

* fix spacing

* record the run

* reverting cypress cli stuff
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
* fix detached from dom issue in modal clicks

* warm up ES cache

* warm up ES cache

* trying to connect cypress w/ dashboard

* fix spacing

* record the run

* reverting cypress cli stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants