Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Update urn tokenizer to tokenize on periods and slashes #4085

Merged
merged 5 commits into from
Mar 3, 2022
Merged

fix(search): Update urn tokenizer to tokenize on periods and slashes #4085

merged 5 commits into from
Mar 3, 2022

Conversation

dexter-mh-lee
Copy link
Contributor

Update urn tokenizer to tokenize on periods and slashes.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 8, 2022 •
edited
Loading

Unit Test Results (build & test)

  71 files  ±0    71 suites  ±0   19m 17s ⏱️ + 4m 25s
618 tests ±0  559 ✔️ +1  59 💤 ±0  0 ❌  - 1 

Results for commit 216df46. ± Comparison against base commit e2f8db7.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka requested changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests to prove this works :)

@shirshanka shirshanka added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Feb 20, 2022
shirshanka
shirshanka approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 5d26c86 into datahub-project:master Mar 3, 2022
@dexter-mh-lee dexter-mh-lee deleted the dl--update-urn-components-tokenizer branch April 4, 2022 23:47
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@maggiehays
fix(search): Update urn tokenizer to tokenize on periods and slashes (d…
1277a8c 
…atahub-project#4085)

* Add period

* Update urn tokenizer

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
pending-submitter-response Issue/request has been reviewed but requires a response from the submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dexter-mh-lee @shirshanka