Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): snowflake - Run authentication validation if default value used #4024

Merged
merged 2 commits into from
Feb 1, 2022
Merged

fix(ingest): snowflake - Run authentication validation if default value used #4024

merged 2 commits into from
Feb 1, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Feb 1, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@treff7es treff7es force-pushed the snowflake_default_auth_fix branch from 92d93ca to 24a8693 Compare February 1, 2022 12:06
@github-actions
Copy link

github-actions bot commented Feb 1, 2022 •
edited
Loading

Unit Test Results (build & test)

  66 files    66 suites   9m 24s ⏱️
582 tests 523 ✔️ 59 💤 0 ❌

Results for commit bdff413.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 771c856 into datahub-project:master Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   38m 32s ⏱️
   279 tests    279 ✔️   0 💤 0 ❌
1 284 runs  1 255 ✔️ 29 💤 0 ❌

Results for commit bdff413.

@treff7es treff7es deleted the snowflake_default_auth_fix branch February 8, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @shirshanka