Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(looker): Adding optional Looker external url base url config #3985

Merged

Conversation

jjoyce0510
Copy link
Collaborator

Adding an optional configuration to specify a base URL on which to mount external URL references to looker charts and dashboards. As requested by the community!

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 26, 2022

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   17m 26s ⏱️ + 7m 24s
505 tests ±0  449 ✔️ ±0  56 💤 ±0  0 ±0 

Results for commit 390b43f. ± Comparison against base commit aeabeec.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   37m 5s ⏱️
   274 tests    273 ✔️   0 💤 1
1 259 runs  1 224 ✔️ 34 💤 1

For more details on these failures, see this check.

Results for commit 390b43f.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit cf38b61 into datahub-project:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants