Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): tighten conditions for restli json transformation #3973

Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 25, 2022

Uses startswith instead of find and limits the replace to one modification.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 25, 2022

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   11m 7s ⏱️ - 3m 4s
505 tests ±0  449 ✔️ ±0  56 💤 ±0  0 ±0 

Results for commit 9f8ff31. ± Comparison against base commit cec541d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 25, 2022

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   32m 13s ⏱️ - 4m 46s
   274 tests ±0     272 ✔️  - 1    0 💤 ±0  2 +1 
1 261 runs  +2  1 231 ✔️ +7  28 💤  - 6  2 +1 

For more details on these failures, see this check.

Results for commit 9f8ff31. ± Comparison against base commit cec541d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit ea5a66b into datahub-project:master Jan 26, 2022
@hsheth2 hsheth2 deleted the tighten-restli-serialization branch January 26, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants