Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): emit flags and stats for profiling telemetry #3969

Merged
merged 8 commits into from
Jan 31, 2022
Merged

feat(ingest): emit flags and stats for profiling telemetry #3969

merged 8 commits into from
Jan 31, 2022

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Jan 25, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files         5 suites   33m 4s ⏱️
   275 tests    274 ✔️   0 💤 1 ❌
1 266 runs  1 235 ✔️ 30 💤 1 ❌

For more details on these failures, see this check.

Results for commit 9300ce5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 25, 2022 •
edited
Loading

Unit Test Results (build & test)

  66 files  ±0    66 suites  ±0   18m 20s ⏱️ + 7m 30s
579 tests ±0  519 ✔️ ±0  59 💤 ±0  0 ❌ ±0  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit 9300ce5. ± Comparison against base commit 111d6d3.

♻️ This comment has been updated with latest results.

@kevinhu kevinhu marked this pull request as ready for review January 27, 2022 14:12
shirshanka
shirshanka approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit b842948 into datahub-project:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinhu @shirshanka