feat(search): supporting chinese glossaryterm full text retrieval(#3914) #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Jan 28, 2022
There was a problem hiding this comment.
Wow - awesome PR!
This looks great to me. Want another pair of eyes on it, then we can ship. (cc. @dexter-mh-lee)
Thank you @Huyueeer!
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Aug 1, 2022
…ahub-project#3914) (datahub-project#3956) * feat(search): supporting chinese glossaryterm full text retrieval(datahub-project#3914) * refactor(search): modify mainTokenizer to appropriate position(datahub-project#3914) Co-authored-by: Shirshanka Das <shirshanka@apache.org>
|
@Huyueeer In Chinese, two Chinese characters are very common. Can you help put MIN_LENGTH configurable? It will be very helpful for Chinese word segmentation |
@xiangqiao123 Sorry, this part should be rebuilt. It seems that you should find the person who implements this part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Change
source of problem: #3914
configure the analyzer to replace word segmentation in other languages supported by
main_tokenizer, The tokenizer that has been tested includessmartcn_tokenizer & ik_smart, Elasticsearch analysis plugins.