Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): check if feature data type is present #3932

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix(ingest): check if feature data type is present #3932

merged 1 commit into from
Jan 27, 2022

Conversation

maaaikoool
Copy link
Contributor

Closes #3925

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

gabe-lyons
gabe-lyons approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @maaaikoool !

@github-actions
Copy link

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   19m 3s ⏱️ + 6m 3s
499 tests  - 5  442 ✔️  - 6  56 💤 ±0  1 ❌ +1 
500 runs   - 4  442 ✔️  - 6  56 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit ba929cc. ± Comparison against base commit d23a5bb.

shirshanka
shirshanka approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 40c5c90 into datahub-project:master Jan 27, 2022
@maaaikoool maaaikoool deleted the fix-MLFeatureDataType-npe branch January 28, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional MLFeatureDataType not null checked
3 participants
@maaaikoool @shirshanka @gabe-lyons