Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ingestion) azure: specify required permission type #3886

Merged

Conversation

iasoon
Copy link
Contributor

@iasoon iasoon commented Jan 13, 2022

In retrospect it's obvious that these should be application-type permissions, but it's easily glossed over when not too familiar with the Azure AD API permissions system.

slack thread: https://datahubspace.slack.com/archives/C029A3M079U/p1636471101266200

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   34m 12s ⏱️
   245 tests    245 ✔️   0 💤 0
1 125 runs  1 099 ✔️ 26 💤 0

Results for commit 1bc3d774.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @iasoon

@shirshanka shirshanka merged commit 285aa1b into datahub-project:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants