Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency for bigquery. #3874

Merged

Conversation

varunbharill
Copy link
Contributor

bigquery depends on bigquery-usage for some sources. So if bigquery-usage plugin is not installed and bigquery plugin is being installed, we run into dependency issues. Hence, moving the dependency to bigquery common.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 12, 2022

Unit Test Results (build & test)

  45 files    45 suites   13m 30s ⏱️
502 tests 450 ✔️ 52 💤 0

Results for commit bedc8f8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jan 12, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   33m 2s ⏱️
   245 tests    245 ✔️   0 💤 0
1 123 runs  1 091 ✔️ 32 💤 0

Results for commit bedc8f8.

♻️ This comment has been updated with latest results.

@varunbharill varunbharill force-pushed the bigquery_dependency_fix branch from 7978c60 to 265e3e6 Compare January 12, 2022 02:13
@varunbharill varunbharill reopened this Jan 12, 2022
@shirshanka shirshanka merged commit cc52e3e into datahub-project:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants