Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: add/change scripts for tests #3840

Merged
merged 1 commit into from
Jan 17, 2022
Merged

perf: add/change scripts for tests #3840

merged 1 commit into from
Jan 17, 2022

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Unit Test Results

     50 files  ±0       50 suites  ±0   43m 0s ⏱️ - 7m 4s
   742 tests ±0     690 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 606 runs  ±0  1 528 ✔️ ±0  78 💤 ±0  0 ❌ ±0 

Results for commit a978336. ± Comparison against base commit 34c27f0.

dexter-mh-lee
dexter-mh-lee approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@dexter-mh-lee dexter-mh-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jjoyce0510
jjoyce0510 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 38e27a8 into datahub-project:master Jan 17, 2022
@anshbansal anshbansal deleted the perf-test-scripts branch January 18, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

@shirshanka shirshanka shirshanka approved these changes

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anshbansal @dexter-mh-lee @shirshanka @jjoyce0510