Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(auth): add Microsoft Azure as an SSO provider (#3779) #3780

Merged

Conversation

cccs-eric
Copy link
Contributor

@cccs-eric cccs-eric commented Dec 21, 2021

This PR adds an how-to page about configuring Microsoft Azure as an OIDC provider.

This page does not configure a groups claim since I was not able to make it work in my deployment. I see groups in the Users & Groups tab, so I'm not sure what is the problem. I can investigate maybe later, but the how-to page still has value.

Related issue: #3779

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@cccs-eric cccs-eric marked this pull request as ready for review December 21, 2021 20:47
@cccs-eric
Copy link
Contributor Author

@jjoyce0510 Let me know if you prefer to wait until I (or someone else) spend some time figuring out the problem with the groups claim. My DataHub seems fine without it, but I am not using all its features. Let me know if you want things to be changed.

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so very much! This is an amazing contribution!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cccs-eric Thank you Eric! A very important contribution for the DataHub community.

@shirshanka shirshanka merged commit acd930d into datahub-project:master Dec 22, 2021
@cccs-eric cccs-eric deleted the docs/auth_sso_azure branch December 22, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants