Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): fix compatibility with google composer #3774

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fix(ingest): fix compatibility with google composer #3774

merged 2 commits into from
Dec 20, 2021

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

Unit Test Results

     45 files       45 suites   45m 47s ⏱️
   644 tests    592 ✔️ 52 💤 0 ❌
1 442 runs  1 368 ✔️ 74 💤 0 ❌

Results for commit eff73a7.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 77e3641 into datahub-project:master Dec 20, 2021
@anshbansal anshbansal deleted the set_version_typing branch December 21, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @shirshanka