Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ingest): fix pytest warning for class starting with Test #3745

Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 15, 2021

Pytest tries to treat classes of the form Test* as classes with tests, which is incorrect here. Adding the underscore prefix resolves the issue.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Pytest tries to treat classes of the form `Test*` as classes with tests, which is incorrect here. Adding the underscore prefix resolves the issue.
@github-actions
Copy link

Unit Test Results

     45 files  ±0       45 suites  ±0   45m 3s ⏱️ - 5m 47s
   638 tests ±0     586 ✔️ ±0  52 💤 ±0  0 ±0 
1 430 runs  ±0  1 362 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit d3ea2f5. ± Comparison against base commit 2e2ed34.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit adf9d2e into datahub-project:master Dec 15, 2021
@hsheth2 hsheth2 deleted the test-usage-common-warning branch December 15, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants