Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enables dbt metadata files to be loaded from URIs #3739

Merged
merged 5 commits into from
Dec 15, 2021
Merged

feat: enables dbt metadata files to be loaded from URIs #3739

merged 5 commits into from
Dec 15, 2021

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 14, 2021 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

Unit Test Results

     45 files  ±0       45 suites  ±0   44m 2s ⏱️ +47s
   638 tests ±0     586 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 430 runs  +2  1 362 ✔️ +8  68 💤  - 6  0 ❌ ±0 

Results for commit 4a7d78f. ± Comparison against base commit adf9d2e.

♻️ This comment has been updated with latest results.

@sgomezvillamor sgomezvillamor marked this pull request as ready for review December 15, 2021 09:31
@sgomezvillamor
Merge branch 'master' into dbt_config_uris
0aff78d 
# Conflicts:
#	docker/quickstart/docker-compose-with-dgraph.quickstart.yml
#	docker/quickstart/docker-compose-with-elasticsearch.quickstart.yml
#	docker/quickstart/docker-compose-with-neo4j.quickstart.yml
@sgomezvillamor
fix: fixes merge
1c3cb4e
@sgomezvillamor sgomezvillamor marked this pull request as draft December 15, 2021 11:04
@sgomezvillamor sgomezvillamor marked this pull request as ready for review December 15, 2021 16:33
shirshanka
shirshanka approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this contrib @sgomezvillamor

@shirshanka shirshanka merged commit c59c63e into datahub-project:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @shirshanka