feat(mae/mcl): Make ingestAspect produce both MCLs and MAEs #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Dec 19, 2021
| produceMAETimer.stop(); | ||
|
|
||
| Timer.Context produceMCLTimer = MetricUtils.timer(this.getClass(), "produceMCL").time(); | ||
| produceMetadataChangeLog(urn, entityName, aspectName, aspectSpec, oldValue, updatedValue, oldSystemMetadata, |
There was a problem hiding this comment.
Can we produce to BOTH? (And deprecate consumption via MAE processor?)
There was a problem hiding this comment.
Added produce to both and removed MAE consumer
There was a problem hiding this comment.
Note the produce calls are async under the hood so no impact on latency
dexter-mh-lee
changed the title
jjoyce0510
reviewed
Jan 5, 2022
|
|
||
| _producer.produceMetadataAuditEvent(urn, oldSnapshot, newSnapshot, oldSystemMetadata, newSystemMetadata, operation); | ||
| protected Snapshot buildKeySnapshot(@Nonnull final Urn urn) { |
There was a problem hiding this comment.
Nit: this should prob go below produceMetadataAuditEventForKey
jjoyce0510
reviewed
Jan 5, 2022
| @@ -143,8 +147,17 @@ public void testIngestGetEntity() throws Exception { | |||
| assertTrue(DataTemplateUtil.areEqual(expectedKey, | |||
| readEntity.getValue().getCorpUserSnapshot().getAspects().get(0).getCorpUserKey())); // Key + Info aspect. | |||
|
|
|||
| ArgumentCaptor<MetadataChangeLog> mclCaptor = ArgumentCaptor.forClass(MetadataChangeLog.class); | |||
jjoyce0510
reviewed
Jan 5, 2022
| @@ -9,7 +9,7 @@ | |||
| public class MaeConsumerApplication { | |||
|
|
|||
| public static void main(String[] args) { | |||
| Class<?>[] primarySources = {MaeConsumerApplication.class, com.linkedin.metadata.kafka.MaeConsumerConfig.class}; | |||
| Class<?>[] primarySources = {MaeConsumerApplication.class, MclConsumerConfig.class}; | |||
shirshanka
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are migrating away from the legacy MCE/MAE setup to MCP/MCL setup detailed in this doc https://datahubproject.io/docs/advanced/mcp-mcl/
As the first step, we will change ingestAspect to produce MCLs and MAEs, and remove MAE processor to consume only from MCLs.
We are leaving MAEs as is for now, since there are external dependencies outside of DataHub that may be consuming MAEs. Note, the recommendation is to move to MCLs.
Tested locally and made sure MCLs are created correctly and that MAEs are still correctly produced.
Checklist