Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf-test): changes for perf testing #3728

Merged
merged 1 commit into from
Dec 14, 2021
Merged

feat(perf-test): changes for perf testing #3728

merged 1 commit into from
Dec 14, 2021

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@anshbansal
Copy link
Collaborator Author

The big change is grafana dashboard. Maybe due to version change it has changed a lot when exported.

@github-actions
Copy link

Unit Test Results

     44 files  ±0       44 suites  ±0   41m 31s ⏱️ +43s
   628 tests ±0     576 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 412 runs  +2  1 344 ✔️ +8  68 💤  - 6  0 ❌ ±0 

Results for commit 07adb3f. ± Comparison against base commit b9f67c5.

jjoyce0510
jjoyce0510 reviewed Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a screenshot you can share of the new grafana dashboard?

shirshanka
shirshanka approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit a4ac79d into datahub-project:master Dec 14, 2021
@anshbansal anshbansal deleted the perf_test_changes branch December 14, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @shirshanka @jjoyce0510