Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata-ingestion): fix requirements for m1 preflight checks #3677

Merged

Conversation

gabe-lyons
Copy link
Contributor

Non m1 computers have uname of Darwin as well. We need to also verify the machine hardware name in order to run m1 checks.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Unit Test Results

     43 files   -     1       43 suites   - 1   27m 30s ⏱️ + 1m 16s
   616 tests ±    0     564 ✔️ ±    0  52 💤 ±0  0 ±0 
1 174 runs   - 181  1 106 ✔️  - 181  68 💤 ±0  0 ±0 

Results for commit b8edd6f. ± Comparison against base commit a16c432.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI failures seem unrelated.

@shirshanka shirshanka merged commit b7a732d into datahub-project:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants