Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): fix bug where key/value toggle would appear on schema tabs with no fields #3643

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

gabe-lyons
Copy link
Contributor

Also added some tests to prevent this from happening in the future.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Nov 30, 2021

Unit Test Results

     44 files  ±0       44 suites  ±0   27m 4s ⏱️ -54s
   619 tests ±0     567 ✔️ ±0  52 💤 ±0  0 ±0 
1 358 runs  ±0  1 290 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit ba767ec. ± Comparison against base commit 50122cb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 2f6fca1 into datahub-project:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants