Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): rectify platform urn in kafka connect source #3624

Merged
merged 2 commits into from
Nov 26, 2021
Merged

fix(ingest): rectify platform urn in kafka connect source #3624

merged 2 commits into from
Nov 26, 2021

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

Unit Test Results

     41 files  ±0       41 suites  ±0   25m 20s ⏱️ - 3m 38s
   610 tests ±0     556 ✔️  -   2  52 💤 ±0  2 ❌ +2 
1 347 runs   - 2  1 270 ✔️  - 11  74 💤 +6  3 ❌ +3 

For more details on these failures, see this check.

Results for commit b1c033c. ± Comparison against base commit 5886e63.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 637d054 into datahub-project:master Nov 26, 2021
@mayurinehate mayurinehate deleted the kakfa_connect_platform_fix branch April 6, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @shirshanka