[refactor] - Remove GMS GraphQL Service #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like flaky tests..need a re-run |
|
Yayyyyy! Thank you Arun! |
jjoyce0510
reviewed
Nov 22, 2021
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| To deploy a new instance of DataHub, perform the following steps. | |||
|
|
|||
| 1. Install [docker](https://docs.docker.com/install/) and [docker-compose](https://docs.docker.com/compose/install/) (if | |||
| 1. Install [docker](https://docs.docker.com/install/), [jq](https://stedolan.github.io/jq/download/) and [docker-compose](https://docs.docker.com/compose/install/) (if | |||
jjoyce0510
approved these changes
Nov 22, 2021
|
Seems that CI is failing - once that is resolved this should be good |
|
It's not clear to me why it's failing, @arunvasudevan can you merge latest master into this branch and try once more? Seems unrelated to your changes: https://github.com/linkedin/datahub/runs/4279078587?check_suite_focus=true |
|
Sure! |
arunvasudevan
force-pushed
the
remove_gms_graphql_service
branch
from
cd5e291 to
0a87112
Compare
|
@jjoyce0510 CI Looks good now. |
|
LGTM. Thanks again! |
shirshanka
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Back in Jan'21 when GMS did not have a graphql endpoint this service was added, now that GMS itself hosts both Rest.li and GraphQL endpoints there i snot reason for this service to exist. So, cleaning it up.
Also, found a JQ dependency while installing datahub so added to the quickstart.