feat(profiler): dynamically combine queries #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhu
reviewed
Nov 16, 2021
metadata-ingestion/src/datahub/ingestion/source/ge_data_profiler.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/ge_data_profiler.py
Outdated
Show resolved
Hide resolved
rslanka
reviewed
Nov 18, 2021
metadata-ingestion/src/datahub/utilities/sqlalchemy_query_combiner.py
Outdated
Show resolved
Hide resolved
rslanka
reviewed
Nov 18, 2021
metadata-ingestion/src/datahub/utilities/sqlalchemy_query_combiner.py
Outdated
Show resolved
Hide resolved
rslanka
reviewed
Nov 18, 2021
shirshanka
approved these changes
Nov 24, 2021
swaroopjagadish
added a commit
to swaroopjagadish/datahub
that referenced
this pull request
Nov 28, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GE profiler issues a ton of queries that each return a single number or a single row. This PR adds support for dynamically combining these queries together at runtime, which reduces the total number of queries issued.
Performance
Using the same testing setup as #3369 and #3510.
Small table - 9 columns, 500 rows
Medium table - 16 columns, 60k rows
These changes really shine when
turn_off_expensive_profiling_metricsis enabled, where it yields a 2-3x speedup.Checklist