Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfg): Add configurable GCP log page size #3556

Merged

Conversation

jjoyce0510
Copy link
Collaborator

As requested here: https://datahubspace.slack.com/archives/CUMUWQU66/p1636612410341100

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

Unit Test Results

     41 files  +    5       41 suites  +5   27m 53s ⏱️ +53s
   610 tests +106     558 ✔️ +106  52 💤 ±0  0 ±0 
1 347 runs  +108  1 273 ✔️ +102  74 💤 +6  0 ±0 

Results for commit c5d065e. ± Comparison against base commit 504a72a.

♻️ This comment has been updated with latest results.

@hyunminch
Copy link
Contributor

Hey @jjoyce0510 really appreciate your work 🙏

I am wondering if you could also update bigquery.py as well since its lineage computation also seems to depend on GCP_LOGGING_PAGE_SIZE.

Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 3e284d8 into datahub-project:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants