Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Provide filtering capability for Sub Types inside the UI #3479

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

jjoyce0510
Copy link
Collaborator

This PR enables filtering for entities by their subtypes. This is useful in differentiating top-level datasets from views, tables, looker explores, etc!

Screen Shot 2021-10-27 at 5 31 31 PM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@@ -3,7 +3,7 @@
source:
type: "file"
config:
filename: "./examples/mce_files/bootstrap_mce.json"
filename: "./tests/integration/lookml/expected_output.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsies

@github-actions
Copy link

github-actions bot commented Oct 28, 2021

Unit Test Results

     58 files  ±0       58 suites  ±0   22m 0s ⏱️ + 1m 19s
   525 tests ±0     473 ✔️ ±0  52 💤 ±0  0 ±0 
1 174 runs  ±0  1 106 ✔️ +6  68 💤  - 6  0 ±0 

Results for commit 2362e9c. ± Comparison against base commit 4b6860e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 6f72536 into datahub-project:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants