-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(recommendations): Recommendations infra P1 #3455
Merged
shirshanka
merged 69 commits into
datahub-project:master
from
jjoyce0510:recommendations-infra
Oct 27, 2021
Merged
feat(recommendations): Recommendations infra P1 #3455
shirshanka
merged 69 commits into
datahub-project:master
from
jjoyce0510:recommendations-infra
Oct 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atahub-fork into recommendations-base
…atahub-fork into recommendations-base
…atahub-fork into recommendations-base
…atahub-fork into recommendations-base
…atahub-fork into recommendations-base
jjoyce0510
commented
Oct 26, 2021
.../java/com/linkedin/datahub/graphql/resolvers/recommendation/ListRecommendationsResolver.java
Show resolved
Hide resolved
gabe-lyons
reviewed
Oct 26, 2021
gabe-lyons
reviewed
Oct 26, 2021
gabe-lyons
reviewed
Oct 26, 2021
gabe-lyons
reviewed
Oct 26, 2021
gabe-lyons
reviewed
Oct 26, 2021
datahub-web-react/src/app/recommendations/renderer/EntityNameListRenderer.tsx
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Oct 26, 2021
datahub-web-react/src/app/recommendations/renderer/EntityNameListRenderer.tsx
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Oct 26, 2021
datahub-web-react/src/app/recommendations/renderer/RecommendationsRenderer.ts
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Oct 26, 2021
datahub-web-react/src/app/recommendations/renderer/component/TagSearchList.tsx
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Oct 26, 2021
gabe-lyons
reviewed
Oct 26, 2021
gabe-lyons
reviewed
Oct 26, 2021
shirshanka
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Really excited to see Recommendations in action!
maggiehays
pushed a commit
to maggiehays/datahub
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces extensible infrastructure required for displaying catalog recommendations in the UI! It includes the surface area for presenting server-driven recommendations on the home page, search page, and entity pages.
Changes
The fun parts:
Server
UI
Screenshots
Home Page:
Search Page:
Status
Ready for review.
Checklist