Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recommendations): Recommendations infra P1 #3455

Merged
merged 69 commits into from
Oct 27, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Oct 26, 2021

Summary
This PR introduces extensible infrastructure required for displaying catalog recommendations in the UI! It includes the surface area for presenting server-driven recommendations on the home page, search page, and entity pages.

Changes

The fun parts:

Server

  • RecommendationService for sourcing candidates for recommendations to present to the UI in a given UI
  • RecommendationCandidateSource, an interface to implement for generating recommendations. Implementations include RecentlyViewed, HighlyUsed, TopPlatforms, TopTags, TopTerms
  • RecommendationModuleRanker for ranking the recommended results

UI

  • RecommendationRendererRegistry for registering the handlers invoked to render recommendations for each render type

Screenshots
Home Page:

Screen Shot 2021-10-22 at 4 44 09 PM

Search Page:

Screen Shot 2021-10-25 at 7 26 34 PM

Status
Ready for review.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Oct 27, 2021

Unit Test Results

     58 files  +2       58 suites  +2   20m 15s ⏱️ - 3m 37s
   525 tests +7     473 ✔️ +7  52 💤 ±0  0 ±0 
1 174 runs  +7  1 100 ✔️ +1  74 💤 +6  0 ±0 

Results for commit ee2e0ab. ± Comparison against base commit 87e93ab.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Really excited to see Recommendations in action!

@shirshanka shirshanka merged commit 2f03ad8 into datahub-project:master Oct 27, 2021
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants