Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for specialization of models through subtypes with … #3338

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

swaroopjagadish
Copy link
Contributor

…looker integration

This PR

  • Adds a new aspect called SubTypes to allow for specializing of the base models (like Datasets).
  • Allows this aspect to be added to the Dataset Entity without needing to be added to the DatasetSnapshot model
  • Adds support for Looker views and explore ingestion to emit this new aspect, while being compatible with old servers that don't have this aspect yet
  • Adds support in the UI to use the subtype information to specialize the rendering

Subtypes-rendered

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks pretty neat.

@shirshanka shirshanka merged commit 0d2454b into datahub-project:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants