Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): support user group filtering for Azure AD #3312

Merged
merged 17 commits into from
Oct 6, 2021
Merged

feat(ingest): support user group filtering for Azure AD #3312

merged 17 commits into from
Oct 6, 2021

Conversation

vlavorini
Copy link
Contributor

New functionalities:

  • AllowDenyPattern to filter Users and Groups
  • option to add only Users belonging to the selected groups

Fix:

  • pagination in gathering results from MS Graph

.. and some code cleaning

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@vlavorini
fix(azure_ad): urllib.quote to urllib.unquote
a361a73
@vlavorini
fix(azure_ad): updated group names in the UI
4b021be
@vlavorini
Merge branch 'linkedin:master' into ad_groups_names
4f62b77
@vlavorini
Merge branch 'ad_groups_names' of github.com:CIPEO/datahub into ad_gr…
6f46d9d 
…oups_names
@vlavorini
feat(azure_ad): Users n Groups can be selected
0cd0c30
@vlavorini
feat(azure_ad): Users n Groups can be filtered
e46a58b
@vlavorini
Merge branch 'linkedin:master' into ad_selection
88d6e3f
@vlavorini
feat(azure_ad): Users n Groups can be filtered
fbe1834
@vlavorini
Merge remote-tracking branch 'origin/ad_selection' into ad_selection
75f300c
@vlavorini
clean(azure_ad): removed commented code
bebc31e
@vlavorini
fix(azure_ad): linting
2161809
@vlavorini
tests(azure_ad): test
6636b41
@vlavorini
test(azure_ad): ignore order in ingestion dicts
6fe636f
@vlavorini
test(azure_ad): linting
9070f45
@vlavorini
test(azure_ad): linting
39a955e
@vlavorini
test(azure_ad): linting
fad51c4
@vlavorini
test(azure_ad): corrected test
7499880
shirshanka
shirshanka approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

metadata-ingestion/src/datahub/ingestion/source/identity/azure_ad.py
def get_workunits(self) -> Iterable[MetadataWorkUnit]:
# for future developers: The actual logic of this ingestion wants to be executed, in order:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@shirshanka shirshanka changed the title Ad selection feat(ingest): support user group filtering for Azure AD Oct 6, 2021
@shirshanka shirshanka merged commit 9cb71d9 into datahub-project:master Oct 6, 2021
@vlavorini vlavorini deleted the ad_selection branch October 6, 2021 06:34
jgiannuzzi pushed a commit to G-Research/datahub that referenced this pull request Oct 6, 2021
@vlavorini @jgiannuzzi
feat(ingest): support user group filtering for Azure AD (datahub-proj…
583efda 
…ect#3312)
swaroopjagadish pushed a commit to swaroopjagadish/datahub that referenced this pull request Oct 7, 2021
@vlavorini @swaroopjagadish
feat(ingest): support user group filtering for Azure AD (datahub-proj…
0665792 
…ect#3312)
@martimors martimors mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlavorini @shirshanka