(fix) Set ebean transaction level to be repeatable read #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall this looks good to me, but I haven't done any performance testing. My expectation is that this doesn't change MySQL performance. |
xdl
added a commit
to G-Research/datahub
that referenced
this pull request
Oct 4, 2021
xdl
added a commit
to G-Research/datahub
that referenced
this pull request
Oct 5, 2021
…e read (datahub-project#3285)" This reverts commit afc4501.
jgiannuzzi
pushed a commit
to G-Research/datahub
that referenced
this pull request
Oct 6, 2021
swaroopjagadish
pushed a commit
to swaroopjagadish/datahub
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of aspect versioning relies on the transactions to be with the isolation level of repeatable read in order to avoid lost updates (as discussed in https://datahubproject.io/docs/advanced/aspect-versioning/#transaction-isolation-1 and illustrated in #3231).
Although the default isolation level is repeatable read for MySQL, ebean sets the default transaction isolation to be read committed (https://github.com/ebean-orm/ebean-datasource/blob/master/ebean-datasource-api/src/main/java/io/ebean/datasource/DataSourceConfig.java#L38); this PR ensures that the transactions use the repeatable read isolation level.
Another option would be to set it as the default/make it configurable (e.g. in https://github.com/linkedin/datahub/blob/master/metadata-service/factories/src/main/java/com/linkedin/gms/factory/common/LocalEbeanServerConfigFactory.java) - regardless, @dexter-mh-lee should run some performance regression testing before merging in.