Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): Redash add parse_table_names_from_sql feature and multiple refactor #3267

Merged
merged 4 commits into from
Oct 6, 2021
Merged

feat(ingest): Redash add parse_table_names_from_sql feature and multiple refactor #3267

merged 4 commits into from
Oct 6, 2021

Conversation

taufiqibrahim
Copy link
Contributor

@taufiqibrahim taufiqibrahim commented Sep 20, 2021 •
edited
Loading

  • Add feature parse table names from SQL
  • Adding QualifiedNameParser and several extended dataclasses for parsing table name into fully qualified name based on database type. As an example, table name orders in Postgres database should be normalized into databaseName.public.orders if only table name part given
  • Some small refactors to improve

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@taufiqibrahim taufiqibrahim marked this pull request as ready for review September 20, 2021 11:42
shirshanka
shirshanka approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @taufiqibrahim

@shirshanka shirshanka merged commit ed38168 into datahub-project:master Oct 6, 2021
jgiannuzzi pushed a commit to G-Research/datahub that referenced this pull request Oct 6, 2021
@taufiqibrahim @jgiannuzzi
feat(ingest): add support for parsing lineage for redash connector (d…
d4f8256 
…atahub-project#3267)

Co-authored-by: tibrahim <taufiq.ibrahim@bizzy.co.id>
swaroopjagadish pushed a commit to swaroopjagadish/datahub that referenced this pull request Oct 7, 2021
@taufiqibrahim @swaroopjagadish
feat(ingest): add support for parsing lineage for redash connector (d…
449a9f4 
…atahub-project#3267)

Co-authored-by: tibrahim <taufiq.ibrahim@bizzy.co.id>
@taufiqibrahim taufiqibrahim deleted the redash branch October 12, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taufiqibrahim @shirshanka