fix(local-development): fix proxy for login route #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging in while developing on the react app caused some proxy issues. This only occurred while loading the react app in development mode while not logged in.
The issue was that the login page was proxied to the frontend server and served from there. It in turn had references to the frontend server's generated bundles. However, the bundle fetching was not proxied. Since the generated bundle ids are randomly created, the development react server would not find the frontend server's bundle ids.
This fix stops the login page from being proxied to the frontend server so the correct bundle ids are included in the page.
Checklist