Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql): Allow explicit JSON null in GraphQL endpoint #3199

Merged
merged 2 commits into from
Sep 3, 2021
Merged

fix(graphql): Allow explicit JSON null in GraphQL endpoint #3199

merged 2 commits into from
Sep 3, 2021

Conversation

jjoyce0510
Copy link
Collaborator

Title says it. GraphiQL passes an explicit null value when variables are not present. Supporting this case.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@shirshanka shirshanka merged commit f0fff0c into datahub-project:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@dexter-mh-lee dexter-mh-lee dexter-mh-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjoyce0510 @dexter-mh-lee @shirshanka