-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(access control): Fine-Grained Access Control M1 #3182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirshanka
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excited for this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Summary
This PR implements the first milestone of Fine-Grained Access Control, which was demo'd in Townhall for August: https://www.youtube.com/watch?v=3joZINi3ti4, along with other misc. cleanup and refactoring.
In a nutshell, fine grained access control allows DataHub admins to declare access policies defining who can do what on the platform. This experience is available via the UI on a new left side slide out panel, which we are calling the "Control Center".
Much of what you find implemented is based on the Fine Grained Access Control RFC, which was published at the beginning of summer. To come to this implementation, we synthesized feedback from the community around that RFC. Many of the concepts remain, most notably: Resources, Actors, Privileges (formerly actions), Policies, and Authorizers.
For more information about the Policies feature, see the new Policies Guide. Note that in future releases, Policies will be enabled by default (though they can be disabled).
Changes
- Metadata: edit owners, edit tags, edit documentation, edit links, edit entire entity, etc.
- Platform: manage policies, view analytics, coming soon manage users and groups.
Compatibility
These changes should be fully backwards compatible. Note that the Analytics view is now located in the left side slide out menu, and users must have the 'VIEW_ANALYTICS' privilege to see it in their UI.
Screenshots
Checklist