feat(sdk): structured properties - add support for listing #12283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
shirshanka
force-pushed
the
sd--structured-props-list-api
branch
from
6b6daa3 to
261f987
Compare
hsheth2
approved these changes
Jan 9, 2025
| name="list", | ||
| ) | ||
| @click.option("--details/--no-details", is_flag=True, default=True) | ||
| @click.option("--to-file", required=False, type=str) |
There was a problem hiding this comment.
imo having the to file option is strange - it should just print to stdout, and the user can redirect the output to a file if they want
There was a problem hiding this comment.
our structured properties file option actually supports multiple structured properties in the same file ... so it makes sense to have a --to-file option which writes out in the same yaml format that we support on the upsert call.
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
llance
pushed a commit
to llance/datahub
that referenced
this pull request
Jan 13, 2025
llance
pushed a commit
to llance/datahub
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement inspired by this question
listto thepropertiescommand in thedatahubcliChecklist