fix(ingest): downgrade column type mapping warning to info

[hsheth2]

Also removes some dead code from the s3/abs sources.

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• New Features

  • Enhanced logging mechanisms for column type mapping, providing clearer and more informative messages to help users identify issues quickly.

• Bug Fixes

  • Removed outdated and unused imports to streamline functionality and improve maintainability.

• Refactor

  • Simplified type handling and schema management for better performance and consistency across various ingestion sources.
  • Removed deprecated functions that no longer align with the current handling of column types.

[coderabbitai]

Walkthrough

The recent changes across multiple files greatly improve the clarity and maintainability of the codebase. By removing unused imports and simplifying type handling, the structure has been streamlined, particularly in type mapping functions. Additionally, logging mechanisms have been enhanced to provide clearer context for issues related to column type mapping, facilitating easier debugging. Overall, these adjustments reflect a thoughtful refactoring aimed at improving functionality and reducing complexity.

Changes

Files	Change Summary
metadata-ingestion/src/datahub/ingestion/source/abs/source.py metadata-ingestion/src/datahub/ingestion/source/s3/source.py	Removed unused imports and the get_column_type function, simplifying type handling and enhancing maintainability.
metadata-ingestion/src/datahub/ingestion/source/dbt/dbt_common.py metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py	Improved logging for column type mapping issues, replacing warnings with structured informational messages that include context.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DataHub
    participant ReportSystem

    User->>DataHub: Request dataset processing
    DataHub->>ReportSystem: Log processing info
    ReportSystem-->>DataHub: Provide context
    DataHub-->>User: Return dataset processing results

Loading

Poem

🐇 In fields of code, where rabbits play,
We’ve tidied imports, cleared the fray.
With clearer logs that softly chime,
Each column’s tale now told in rhyme.
So hop along, dear friends, rejoice,
For simpler paths, let’s cheer with voice! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 900c259 and c4ce835.

Files selected for processing (4)

• metadata-ingestion/src/datahub/ingestion/source/abs/source.py (4 hunks)
• metadata-ingestion/src/datahub/ingestion/source/dbt/dbt_common.py (1 hunks)
• metadata-ingestion/src/datahub/ingestion/source/s3/source.py (5 hunks)
• metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py (1 hunks)

Additional comments not posted (6)

metadata-ingestion/src/datahub/ingestion/source/abs/source.py (2)

11-11: Ensure imports are necessary.

The imports from typing are extensive. Verify that all imported types are used in the file.

Verification successful

---

All imported types from typing are used.

The imports from typing are indeed utilized within the file. No unnecessary imports were found.

• Dict
• Iterable
• List
• Optional
• Tuple

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of imported types from `typing`.

# Test: Check for usage of each imported type. Expect: Each type should be used at least once.
rg --type python -o 'Dict|Iterable|List|Optional|Tuple' metadata-ingestion/src/datahub/ingestion/source/abs/source.py

Length of output: 150

---

Script:

#!/bin/bash
# Description: Verify the usage of imported types from `typing`.

# Test: Check for usage of each imported type. Expect: Each type should be used at least once.
rg -o 'Dict|Iterable|List|Optional|Tuple' metadata-ingestion/src/datahub/ingestion/source/abs/source.py

Length of output: 286

---

Line range hint 83-139: Verify schema inference logic.

Ensure that the schema inference logic in get_fields is complete and does not rely on the removed get_column_type function.

Verification successful

---

Schema inference logic is independent of get_column_type.

The get_fields function does not reference get_column_type, indicating that its schema inference logic is self-contained and complete without relying on the removed function.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify schema inference logic in `get_fields`.

# Test: Check for any references to `get_column_type` in the file. Expect: No references should be found.
rg --type python 'get_column_type' metadata-ingestion/src/datahub/ingestion/source/abs/source.py

Length of output: 127

---

Script:

#!/bin/bash
# Description: Verify schema inference logic in `get_fields`.

# Test: Check for any references to `get_column_type` in the file. Expect: No references should be found.
rg --type py 'get_column_type' metadata-ingestion/src/datahub/ingestion/source/abs/source.py

Length of output: 92

metadata-ingestion/src/datahub/ingestion/source/s3/source.py (2)

422-422: Verify modification of type parameter.

The type parameter in add_partition_columns_to_schema has been changed to use SchemaFieldDataTypeClass. Ensure that this is the intended change and does not affect functionality.

---

11-11: Ensure imports are necessary.

The imports from typing are extensive. Verify that all imported types are used in the file.

Verification successful

---

All imported types from typing are necessary.

The imports Dict, Iterable, List, Optional, and Tuple are all used in the file and should be retained. No further action is needed regarding these imports.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of imported types from `typing`.

# Test: Check for usage of each imported type. Expect: Each type should be used at least once.
rg --type python -o 'Dict|Iterable|List|Optional|Tuple' metadata-ingestion/src/datahub/ingestion/source/s3/source.py

Length of output: 149

---

Script:

#!/bin/bash
# Description: Verify the usage of imported types from `typing` in the specified file.

# Test: Check for usage of each imported type. Expect: Each type should be used at least once.
rg -o 'Dict|Iterable|List|Optional|Tuple' metadata-ingestion/src/datahub/ingestion/source/s3/source.py

Length of output: 308

metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py (1)

266-270: Verify logging level change.

The logging level for unrecognized column types has been changed from warning to info. Ensure that this change aligns with the PR objectives and does not affect issue monitoring.

metadata-ingestion/src/datahub/ingestion/source/dbt/dbt_common.py (1)

852-856: LGTM! But verify the impact on the logging system.

The change from report.report_warning to report.info aligns with the PR objective to reduce log verbosity. The structured logging format with title, message, and context enhances clarity.

However, ensure that the logging system correctly captures these info messages and that any relevant documentation or monitoring systems are updated accordingly.