Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for runAssertion, runAssertions, and runAssertionsForAsset APIs #10605

Merged
merged 1 commit into from
May 31, 2024
Merged

Add support for runAssertion, runAssertions, and runAssertionsForAsset APIs #10605

merged 1 commit into from
May 31, 2024

Conversation

noggi
Copy link
Collaborator

@noggi noggi commented May 28, 2024

As titled

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@jjoyce0510

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels May 28, 2024
@noggi noggi force-pushed the ak--run-assertions-sdk branch from 0665000 to 9a6cba3 Compare May 28, 2024 22:09
@noggi noggi force-pushed the ak--run-assertions-sdk branch 4 times, most recently from b5a6be0 to 9d2675a Compare May 28, 2024 22:35
@noggi noggi force-pushed the ak--run-assertions-sdk branch 2 times, most recently from dc3e573 to 8441a79 Compare May 28, 2024 23:27
@noggi noggi force-pushed the ak--run-assertions-sdk branch from 8441a79 to b6daf8a Compare May 29, 2024 21:59
@noggi
Copy link
Collaborator Author

noggi commented May 29, 2024

Added async flag

jjoyce0510
jjoyce0510 reviewed May 29, 2024
View reviewed changes
metadata-ingestion/src/datahub/ingestion/graph/client.py
urn: str,
save_result: bool = True,
parameters: Optional[Dict[str, str]] = {},
async_flag: bool = False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just name this: "async"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, python doesn't like it I guess because it conflicts with its co-routine keywords (async/await).

jjoyce0510
jjoyce0510 reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment:

async_flag -> async is fine! It matches save_result better with this name :)

@noggi noggi force-pushed the ak--run-assertions-sdk branch from b6daf8a to 77d4ada Compare May 30, 2024 01:15
@noggi noggi force-pushed the ak--run-assertions-sdk branch from 77d4ada to 086b231 Compare May 31, 2024 20:08
@noggi noggi force-pushed the ak--run-assertions-sdk branch from 086b231 to 5df05c6 Compare May 31, 2024 20:20
@noggi noggi force-pushed the ak--run-assertions-sdk branch from 5df05c6 to 2b21edd Compare May 31, 2024 20:29
@noggi noggi merged commit b542143 into master May 31, 2024
58 checks passed
@noggi noggi deleted the ak--run-assertions-sdk branch May 31, 2024 21:23
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@noggi @sleeperdeep
Add support for runAssertion, runAssertions, and runAssertionsForAsse…
30ca00a 
…t APIs (datahub-project#10605)
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@noggi @yoonhyejin
Add support for runAssertion, runAssertions, and runAssertionsForAsse…
929dcfb 
…t APIs (#10605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noggi @jjoyce0510