Skip to content

Commit

Permalink
frontend lint
Browse files Browse the repository at this point in the history
  • Loading branch information
asikowitz committed Feb 4, 2025
1 parent 0382530 commit d63cb09
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default function MLModelSummary() {
if (!state || state.length === 0) return '-';
const result = state[0]?.result?.resultType;
const statusColor = result === DataProcessInstanceRunResultType.Success ? 'green' : 'red';
return <Pill label={capitalize(result)} colorScheme={statusColor} clickable={false} />;
return <Pill label={capitalize(result)} color={statusColor} clickable={false} />;

Check warning on line 49 in datahub-web-react/src/app/entity/dataProcessInstance/profile/DataProcessInstanceSummary.tsx

View check run for this annotation

Codecov / codecov/patch

datahub-web-react/src/app/entity/dataProcessInstance/profile/DataProcessInstanceSummary.tsx#L49

Added line #L49 was not covered by tests
};

const formatDuration = (state) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export default function MLModelSummary() {
<Pill
label={alias.versionTag ?? '-'}
key={alias.versionTag}
colorScheme="blue"
color="blue"

Check warning on line 114 in datahub-web-react/src/app/entity/mlModel/profile/MLModelSummary.tsx

View check run for this annotation

Codecov / codecov/patch

datahub-web-react/src/app/entity/mlModel/profile/MLModelSummary.tsx#L114

Added line #L114 was not covered by tests
clickable={false}
/>
))}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,7 @@ export default function MLGroupModels() {
return (
<TagContainer>
{aliases.map((alias) => (
<Pill
key={alias.versionTag}
label={alias.versionTag}
colorScheme="blue"
clickable={false}
/>
<Pill key={alias.versionTag} label={alias.versionTag} color="blue" clickable={false} />

Check warning on line 121 in datahub-web-react/src/app/entity/mlModelGroup/profile/ModelGroupModels.tsx

View check run for this annotation

Codecov / codecov/patch

datahub-web-react/src/app/entity/mlModelGroup/profile/ModelGroupModels.tsx#L121

Added line #L121 was not covered by tests
))}
</TagContainer>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,7 @@ const StructuredPropertyBadge = ({ structuredProperties }: Props) => {
overlayInnerStyle={{ width: 250, padding: 16 }}
>
<BadgeContainer>
<Pill
label={propRow?.values[0]?.value?.toString() || ''}
size="sm"
colorScheme="violet"
clickable={false}
/>
<Pill label={propRow?.values[0]?.value?.toString() || ''} size="sm" color="violet" clickable={false} />
</BadgeContainer>
</StyledTooltip>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default function DataProcessInstanceSummary() {
if (!state || state.length === 0) return '-';
const result = state[0]?.result?.resultType;
const statusColor = result === DataProcessInstanceRunResultType.Success ? 'green' : 'red';
return <Pill label={capitalize(result)} colorScheme={statusColor} clickable={false} />;
return <Pill label={capitalize(result)} color={statusColor} clickable={false} />;

Check warning on line 49 in datahub-web-react/src/app/entityV2/dataProcessInstance/profile/DataProcessInstanceSummary.tsx

View check run for this annotation

Codecov / codecov/patch

datahub-web-react/src/app/entityV2/dataProcessInstance/profile/DataProcessInstanceSummary.tsx#L49

Added line #L49 was not covered by tests
};

const formatDuration = (state) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export default function DataProcessInstanceRightColumn({ startTime, duration, st
{status && (
<>
<StatContainer>
<Pill label={capitalize(status)} colorScheme={statusPillColor} clickable={false} />
<Pill label={capitalize(status)} color={statusPillColor} clickable={false} />

Check warning on line 81 in datahub-web-react/src/app/preview/DataProcessInstanceRightColumn.tsx

View check run for this annotation

Codecov / codecov/patch

datahub-web-react/src/app/preview/DataProcessInstanceRightColumn.tsx#L81

Added line #L81 was not covered by tests
</StatContainer>
</>
)}
Expand Down

0 comments on commit d63cb09

Please sign in to comment.