This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
chore: change console log to avoid displaying cookie #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we print out the cookie information of the user into the logs. I don't fully recall why I used to do this, but it's certainly not a good idea. The developer, or anyone with access to the logs, can impersonate the person very easily by stealing that cookie.
Decisions/Tradeoffs
I've removed the logging that we do of the cookie, that's it.
As for the old pieces of information that have been logged, since all the sessions expire and new IDs are generated, they can no longer be used to impersonate someone, so that's not much of an issue
How to test
We'll just test this in staging directly, what's the potential for harm here come on
Type of change