Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

chore: change console log to avoid displaying cookie #23

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

cloudhary
Copy link

Description

Currently, we print out the cookie information of the user into the logs. I don't fully recall why I used to do this, but it's certainly not a good idea. The developer, or anyone with access to the logs, can impersonate the person very easily by stealing that cookie.

Decisions/Tradeoffs

I've removed the logging that we do of the cookie, that's it.

As for the old pieces of information that have been logged, since all the sessions expire and new IDs are generated, they can no longer be used to impersonate someone, so that's not much of an issue

How to test

We'll just test this in staging directly, what's the potential for harm here come on

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@danielkhoo
Copy link

what's the potential for harm here come on
DON'T JINX US!!

@danielkhoo danielkhoo merged commit da79576 into master Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants