EZP-29984: Fix LIKE support for * as wildcard across engines, deprec…

…ate % usage (ezsystems#2517) Beyond just LIKE, this also fixes the following: * Add LegacySE search Field Criteria support for RelationList FieldType * Add LegacySE search Field Criteria support for Author FieldType * Add LegacySE search Field Criteria support for RichText FieldType * Handle 'Simple' field types when LIKE and int column as EQ, as int and LIKE does not mix well on SQL
datafactory · Feb 1, 2019 · 7129d21 · 7129d21
1 parent c16e85f
commit 7129d21
Show file tree

Hide file tree

Showing 45 changed files with 296 additions and 468 deletions.
diff --git a/eZ/Publish/API/Repository/Tests/FieldType/AuthorIntegrationTest.php b/eZ/Publish/API/Repository/Tests/FieldType/AuthorIntegrationTest.php
@@ -138,7 +138,7 @@ public function getFieldName()
     public function assertFieldDataLoadedCorrect(Field $field)
     {
         $this->assertInstanceOf(
-            'eZ\\Publish\\Core\\FieldType\\Author\\Value',
+            AuthorValue::class,
             $field->value
         );
 
@@ -219,7 +219,7 @@ public function getValidUpdateFieldData()
     public function assertUpdatedFieldDataLoadedCorrect(Field $field)
     {
         $this->assertInstanceOf(
-            'eZ\\Publish\\Core\\FieldType\\Author\\Value',
+            AuthorValue::class,
             $field->value
         );
 
@@ -279,7 +279,7 @@ public function provideInvalidUpdateFieldData()
     public function assertCopiedFieldDataLoadedCorrectly(Field $field)
     {
         $this->assertInstanceOf(
-            'eZ\\Publish\\Core\\FieldType\\Author\\Value',
+            AuthorValue::class,
             $field->value
         );
 
@@ -411,15 +411,6 @@ public function providerForTestIsNotEmptyValue()
         );
     }
 
-    protected function checkSearchEngineSupport()
-    {
-        if (ltrim(get_class($this->getSetupFactory()), '\\') === 'eZ\\Publish\\API\\Repository\\Tests\\SetupFactory\\Legacy') {
-            $this->markTestSkipped(
-                "'ezauthor' field type is not searchable with Legacy Search Engine"
-            );
-        }
-    }
-
     protected function getValidSearchValueOne()
     {
         return array(

diff --git a/eZ/Publish/API/Repository/Tests/FieldType/DateAndTimeIntegrationTest.php b/eZ/Publish/API/Repository/Tests/FieldType/DateAndTimeIntegrationTest.php
@@ -30,6 +30,16 @@ public function getTypeName()
         return 'ezdatetime';
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    protected function supportsLikeWildcard($value)
+    {
+        parent::supportsLikeWildcard($value);
+
+        return false;
+    }
+
     /**
      * Get expected settings schema.
      *

diff --git a/eZ/Publish/API/Repository/Tests/FieldType/DateIntegrationTest.php b/eZ/Publish/API/Repository/Tests/FieldType/DateIntegrationTest.php
@@ -31,6 +31,16 @@ public function getTypeName()
         return 'ezdate';
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    protected function supportsLikeWildcard($value)
+    {
+        parent::supportsLikeWildcard($value);
+
+        return false;
+    }
+
     /**
      * Get expected settings schema.
      *

diff --git a/eZ/Publish/API/Repository/Tests/FieldType/FileBaseIntegrationTest.php b/eZ/Publish/API/Repository/Tests/FieldType/FileBaseIntegrationTest.php
diff --git a/eZ/Publish/API/Repository/Tests/FieldType/RelationBaseIntegrationTest.php b/eZ/Publish/API/Repository/Tests/FieldType/RelationBaseIntegrationTest.php
diff --git a/eZ/Publish/API/Repository/Tests/FieldType/RelationIntegrationTest.php b/eZ/Publish/API/Repository/Tests/FieldType/RelationIntegrationTest.php
@@ -33,6 +33,16 @@ public function getTypeName()
         return 'ezobjectrelation';
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    protected function supportsLikeWildcard($value)
+    {
+        parent::supportsLikeWildcard($value);
+
+        return false;
+    }
+
     /**
      * @param \eZ\Publish\API\Repository\Values\Content\Content $content
      *