FE changes to support location autocomplete within the NL Search bar #4649
+822
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into autocomplete_fe
dwnoble
reviewed
Oct 2, 2024
| bp = Blueprint("autocomplete", __name__, url_prefix='/api') | ||
|
|
||
|
|
||
| @bp.route('/autocomplete', methods=['GET', 'POST']) |
There was a problem hiding this comment.
I'd use just GET here since the request is read-only and idempotent.
| Json object represnting 5 location predictions for the query. | ||
| """ | ||
| lang = request.args.get('hl') | ||
| original_query = request.args.get('query') |
There was a problem hiding this comment.
should this just be query = ...?
| @@ -0,0 +1,89 @@ | |||
| # Copyright 2023 Google LLC | |||
| Returns: | ||
| List[str]: containing all subqueries to execute. | ||
| """ | ||
| words_in_query = user_query.split(" ") |
| RESPONSE_COUNT_LIMIT = 5 | ||
|
|
||
|
|
||
| def find_queries(user_query: str): |
There was a problem hiding this comment.
Nit: add typing def find_queries(user_query: str) -> List[str]:
(and to other functions below)
| @@ -697,6 +690,16 @@ def placeid2dcid(): | |||
| return Response(json.dumps(result), 200, mimetype='application/json') | |||
|
|
|||
|
|
|||
| @bp.route('/placeid2dcid') | |||
There was a problem hiding this comment.
Is this endpoint still needed?
| @@ -0,0 +1,67 @@ | |||
| # Copyright 2022 Google LLC | |||
| place_id_to_dcid = json.loads(findplacedcid(place_ids).data) | ||
|
|
||
| final_predictions = [] | ||
| # TODO(gmechali): See if we can use typed dataclasses here. |
| @@ -0,0 +1,66 @@ | |||
| # Copyright 2020 Google LLC | |||
| }, []); | ||
|
|
||
| // memoize the debounce call with useMemo | ||
| const SendDebouncedAutoCompleteRequest = useMemo(() => { |
There was a problem hiding this comment.
Nit: sendDebouncedAutoCompleteRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All FE changes to add a dropdown on the NL search bar for autocompleting location search.
See screencast: https://screencast.googleplex.com/cast/NDkxMjUyMjc3MDUxMzkyMHxkZjg3ZDUxMC05MA
Also adds a webdriver test to verify the presence of the suggestion results.