Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wildcard import files in manifest.json #1198

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

ajaits
Copy link
Contributor

@ajaits ajaits commented Jan 23, 2025

Tested with a test import manually with the json:

{
  "import_specifications": [
    {
      "import_name": "TestImport",
      "scripts": ["run.sh"],
      "import_inputs": [
        {
          "template_mcf": "india_census_sample_output.tmcf",
          "cleaned_csv": "india_census_sample_output.csv"
        },
        {
          "template_mcf": "sample_output.tmcf",
          "cleaned_csv": "sample*output.csv"
        }
      ],
      "cron_schedule": "15 22 10 1,7 *"
    }
  ]
}

Files were copied to: https://pantheon.corp.google.com/storage/browser/unresolved_mcf/scripts/test_import/TestImport/2025_01_23T09_14_53_686180_08_00

@ajaits ajaits requested a review from vish-cs January 23, 2025 18:17
@hqpho hqpho removed their assignment Jan 23, 2025
@ajaits ajaits merged commit e27c8c6 into datacommonsorg:master Jan 24, 2025
9 checks passed
Girish3320 pushed a commit to Girish3320/data that referenced this pull request Jan 27, 2025
…g#1198)

* Add support for wildcard import files in manifest.json

* copy source_files to GCS

* fix unit tests

* fix unit tests
shamimansari1988 pushed a commit to shamimansari1988/data that referenced this pull request Jan 27, 2025
…g#1198)

* Add support for wildcard import files in manifest.json

* copy source_files to GCS

* fix unit tests

* fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants