NCES combined pr #1152
Open
NCES combined pr #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "School Type": | ||
| "School_Type", | ||
| "School's Religious Affiliation or Orientation": | ||
| "School_Religion_Affliation", |
There was a problem hiding this comment.
Please fix the spell error "School_Religion_Affliation" to "School_Religion_Affiliation"
| """ | ||
| cols_mapper = { | ||
| "Coeducational": _COEDUCATIONAL, | ||
| "School_Religion_Affliation": _RELIGIOUS_AFFLIATION, |
There was a problem hiding this comment.
Please fix the spell error
- "School_Religion_Affliation" to "School_Religion_Affiliation"
- _RELIGIOUS_AFFLIATION to _RELIGIOUS_AFFILIATION
| "–": "" | ||
| } | ||
|
|
||
| _RELIGIOUS_AFFLIATION = { |
There was a problem hiding this comment.
Fix the spell error: _RELIGIOUS_AFFLIATION to _RELIGIOUS_AFFILIATION
| # Dropping the Duplicate entries based on School ID | ||
| DROP_BY_VALUE = "School ID - NCES Assigned" | ||
| # Renaming column name. | ||
| RENAMEING_PRIVATE_COLUMNS = { |
There was a problem hiding this comment.
Fix spell error: RENAMEING_PRIVATE_COLUMNS to RENAMING_PRIVATE_COLUMNS
There was a problem hiding this comment.
Please add manifest for other two imports.
There was a problem hiding this comment.
Please reduce the "test_data" folder size to less than .5MB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NCES combined PR for District , Private & Public as of Nov 2024