Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query builder (3 of 3): Refactor aggregates #1304

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Dec 12, 2024

Purpose

Refactor aggregates into their own builder. Introduces a new option include_aggregates which can be a list of aggregate keys that will create a sub-set of aggregates to be included in the query.

This only applies to the GraphQL search query but the methods could become a template for aggregates in the REST API search query.

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant