Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude schema.rb from rubocop lint #1123

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

kaysiz
Copy link
Contributor

@kaysiz kaysiz commented Feb 14, 2024

Purpose

Exclude schema.rb from rubocop lint

closes: Add github issue that originated this PR

Approach

Update .rubocop.yml to exclude schema.rb

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kaysiz kaysiz self-assigned this Feb 14, 2024
@kaysiz kaysiz requested a review from a team February 14, 2024 09:21
Copy link
Contributor

@richardhallett richardhallett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, schema.db should be excluded entirely by default:
rubocop/rubocop-rails#166

@kaysiz
Copy link
Contributor Author

kaysiz commented Feb 14, 2024

As far as I can tell, schema.db should be excluded entirely by default: rubocop/rubocop-rails#166

Unfortunately no, https://github.com/datacite/lupo/actions/runs/7898818978/job/21556988597 I have some builds that where failing lint, mybe we need to update our rubocop version :)

Copy link
Contributor

@richardhallett richardhallett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if our configuration is wrong then, not sure what DisabledByDefault does entirely, maybe that stops it.
Anyway your change is fine, but it seems strange that the default ignore doesnt work.

@kaysiz kaysiz merged commit ddaa046 into master Feb 14, 2024
13 checks passed
@kaysiz kaysiz deleted the exclude-lint-schema-file branch February 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants