Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handout #489

Closed
wants to merge 6 commits into from
Closed

Remove handout #489

wants to merge 6 commits into from

Conversation

juanfung
Copy link
Contributor

@juanfung juanfung commented Oct 3, 2023

Closes #464

This PR removes the R handout from both the learners view navigation (via config.yml) and from the learners sub-directory.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-socialsci/compare/md-outputs..md-outputs-PR-489

The following changes were observed in the rendered markdown documents:

 02-starting-with-data.md                           |   12 +-
 04-tidyr.md                                        |   22 +-
 06-rmarkdown.md                                    |    2 +-
 R-handout.md (gone)                                | 1006 -------------
 config.yaml (gone)                                 |   88 --
 data_output/interviews_plotting.csv                |    4 +-
 fig/05-ggplot2-rendered-adding-colors-1.png        |  Bin 17690 -> 17905 bytes
 fig/05-ggplot2-rendered-adding-jitter-1.png        |  Bin 9196 -> 9184 bytes
 fig/05-ggplot2-rendered-adding-width-height-1.png  |  Bin 8825 -> 8787 bytes
 fig/05-ggplot2-rendered-boxplot-exercise-1.png     |  Bin 10245 -> 10225 bytes
 ...-ggplot2-rendered-boxplot-exercise-factor-1.png |  Bin 21609 -> 21252 bytes
 fig/05-ggplot2-rendered-boxplot-with-jitter-1.png  |  Bin 16780 -> 16711 bytes
 fig/05-ggplot2-rendered-color-by-species-1.png     |  Bin 19188 -> 19437 bytes
 fig/05-ggplot2-rendered-scatter-challenge-1.png    |  Bin 18444 -> 18810 bytes
 fig/05-ggplot2-rendered-violin-plot-1.png          |  Bin 27793 -> 27816 bytes
 index.md                                           |    6 +-
 instructor-notes.md                                |   37 +-
 md5sum.txt                                         |   35 +-
 renv.lock (gone)                                   | 1570 --------------------
 19 files changed, 74 insertions(+), 2708 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-10-03 18:23:28 +0000

github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
Copy link
Contributor

@jessesadler jessesadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Worked as expected. The only change that needs to happen is to remove the changes to index.md and instructors/instructor-noted.md, which are from PR #488.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes here are part of PR #488 and should not be changed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes here are part of PR #488 and should not be changed here.

@juanfung
Copy link
Contributor Author

@jessesadler oh dear...it seems i created the handout branch from the instructor notes branch. sloppy! i will fix.

so glad you reviewed!

@juanfung
Copy link
Contributor Author

closing due to messy branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommended updates to handouts
2 participants