-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added azure_managed_identity
block to databricks_storage_credential
and databricks_metastore_data_access
resources
#1354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
=======================================
Coverage 90.11% 90.11%
=======================================
Files 122 122
Lines 10116 10118 +2
=======================================
+ Hits 9116 9118 +2
Misses 637 637
Partials 363 363
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very fast! :-) left some comments.
@@ -53,6 +53,28 @@ resource "databricks_metastore_data_access" "this" { | |||
} | |||
``` | |||
|
|||
For Azure using managed identity as credential (Private Preview) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you get a green light from @annashres to document it publicly for private preview?
If not - please remove this section from registry docs just yet, create a google doc in GTM private preview folder and move it there. And also link it on internal wiki for tf provider and azmi preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anna said it should be fine since the UC is gated as well and we'll ungate MIs when the UC is ungated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it goes to this release :)
azure_managed_identity
block to databricks_storage_credential
and databricks_metastore_data_access
azure_managed_identity
block to databricks_storage_credential
and databricks_metastore_data_access
azure_managed_identity
block to databricks_storage_credential
and databricks_metastore_data_access
resources
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)). * Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)). * Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)). * Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)). * Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)). * Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)). * Apply ownership for UC objects during creation ([#1338](#1338)). * Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)). * Various documentation fixes ([#1350](#1350)). Updated dependency versions: * Bump google.golang.org/api from 0.80.0 to 0.81.0 * Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6 * Bump google.golang.org/api from 0.81.0 to 0.82.0 * Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)). * Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)). * Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)). * Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)). * Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)). * Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)). * Apply ownership for UC objects during creation ([#1338](#1338)). * Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)). * Various documentation fixes ([#1350](#1350)). Updated dependency versions: * Bump google.golang.org/api from 0.80.0 to 0.81.0 * Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6 * Bump google.golang.org/api from 0.81.0 to 0.82.0 * Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
…l` and `databricks_metastore_data_access` resources (databricks#1354)
* Added `delta_sharing_*` support to `databricks_metastore` ([databricks#1334](databricks#1334)). * Added `databricks_git_credentials` pat discovery from common environment variables ([databricks#1353](databricks#1353)). * Added `databricks_permissions` for `databricks_pipeline` ([databricks#1361](databricks#1361)). * Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([databricks#1360](databricks#1360)). * Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([databricks#1354](databricks#1354)). * Update docs regarding importing of `databricks_sql_*` resources ([databricks#1349](databricks#1349)). * Apply ownership for UC objects during creation ([databricks#1338](databricks#1338)). * Re-create purged cluster for `databricks_mount` for Google Storage ([databricks#1333](databricks#1333)). * Various documentation fixes ([databricks#1350](databricks#1350)). Updated dependency versions: * Bump google.golang.org/api from 0.80.0 to 0.81.0 * Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6 * Bump google.golang.org/api from 0.81.0 to 0.82.0 * Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
On Azure, Unity Catalog now supports system assigned managed identity as credentials for
databricks_metastore_data_access
anddatabricks_storage_credential
in addition to service principals.This PR adds support for this as an optional block